[Ffmpeg-cvslog] r6963 - trunk/libavformat/riff.c

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> Hi
>
> On Sat, Nov 11, 2006 at 02:01:34PM +0100, Baptiste Coudurier wrote:
>> Hi
>> 
>> Michael Niedermayer a ?crit :
>> >Hi
>> >
>> >On Sat, Nov 11, 2006 at 01:22:08AM +0000, M?ns Rullg?rd wrote:
>> >>michael <subversion at mplayerhq.hu> writes:
>> >>
>> >>>Author: michael
>> >>>Date: Sat Nov 11 01:29:49 2006
>> >>>New Revision: 6963
>> >>>
>> >>>Modified:
>> >>>   trunk/libavformat/riff.c
>> >>>
>> >>>Log:
>> >>>libnut uses "MP3 " for mp3
>> >>>
>> >>>Modified: trunk/libavformat/riff.c
>> >>>=======================================================================
>> >>>--- trunk/libavformat/riff.c	(original)
>> >>>+++ trunk/libavformat/riff.c	Sat Nov 11 01:29:49 2006
>> >>>@@ -200,6 +200,7 @@
>> >>>     // for NuppelVideo (nuv.c)
>> >>>     { CODEC_ID_PCM_S16LE, MKTAG('R', 'A', 'W', 'A') },
>> >>>     { CODEC_ID_MP3, MKTAG('L', 'A', 'M', 'E') },
>> >>>+    { CODEC_ID_MP3, MKTAG('M', 'P', '3', ' ') },
>> >>Nooooo.  We were trying to get rid of those invalid bogus tags from
>> >>riff.c.  Don't add more of them.
>> >
>> >nut per spec uses the avi-riff tags to identify codecs, libnut uses
>> >"MP3 " ...
>> > ask oded why
>> > but the nut tags do belong in riff.c IMO, furthermore there is no harm
>> > from this wav/avi cant use them anyway as they are too long, also they
>> > are at the end so they wont be selected by default ...
>> >
>> 
>> IMHO, nut uses fourcc, aka 32 bit int that is supposed to identify a 
>> codec, not avi-riff tags,
>
> wrong, to quote the spec:
> fourcc
>     identification for the codec
>     example: "H264"
>     MUST contain 2 or 4 bytes, note, this might be increased in the future
>     if needed
>     the id values used are the same as in avi, so if a codec uses a specific
>     fourcc in avi then the same fourcc MUST be used here

That's about as vague as it gets, and is furthermore completely
irrelevant.  The tables in riff.c are for AVI and WAV.  AVI and WAV
use 16-bit tags for audio.  Hence, "MP3 " is invalid in that table.
If NUT wants to use 32-bit tags for audio, thats fine.  Just don't
claim they are the same as AVI, and don't pollute the RIFF tables with
them.

-- 
M?ns Rullg?rd
mru at inprovide.com