[Ffmpeg-cvslog] r6586 - in trunk/libavcodec: cabac.c cabac.h h264.c

[Uoti Urpala]

On Sun, 2006-10-08 at 23:57 +0300, Uoti Urpala wrote:
> On Sun, 2006-10-08 at 22:37 +0200, Michael Niedermayer wrote:
> > On Sun, Oct 08, 2006 at 04:52:16PM +0300, Uoti Urpala wrote:
> > > On Sun, 2006-10-08 at 13:24 +0200, michael wrote:
> > > > +#else
> > > > +        *state= c->mps_state[s]; //P3:655
> > > 
> > > This line is just left over I suppose?
> > 
> > yes and no ...
> > remove it and the code will be a few % slower
> 
> Why would it be slower? I don't see how setting *state to the same value
> by two different methods consecutively like that could improve
> performance.

I benchmarked it and on Athlon having that line there but removing the
+=2 version was faster, so perhaps it would be better to call the other
version "left over". Anyway ONE of "*state= c->mps_state[s];" and "s+=2;
if(s<128) *state= s;" should be disabled.