[Ffmpeg-cvslog] r6620 - in trunk: libavutil/common.h libpostproc/postprocess.c

[Diego Biurrun]

On Wed, Oct 11, 2006 at 02:56:19AM +0200, Diego Biurrun wrote:
> On Tue, Oct 10, 2006 at 04:50:49PM +0200, Reimar D?ffinger wrote:
> > On Tue, Oct 10, 2006 at 09:49:10AM +0200, diego wrote:
> > > 
> > > Modified:
> > >    trunk/libavutil/common.h
> > >    trunk/libpostproc/postprocess.c
> > > 
> > > Log:
> > > Move sign macro to libavutil.
> > > 
> > > --- trunk/libavutil/common.h	(original)
> > > +++ trunk/libavutil/common.h	Tue Oct 10 09:49:10 2006
> > > @@ -193,6 +193,7 @@
> > >  /* assume b>0 */
> > >  #define ROUNDED_DIV(a,b) (((a)>0 ? (a) + ((b)>>1) : (a) - ((b)>>1))/(b))
> > >  #define ABS(a) ((a) >= 0 ? (a) : (-(a)))
> > > +#define SIGN(a) ((a) > 0 ? 1 : -1)
> > 
> > I'm not too happy with macro names like ABS and SIGN in libavutil
> > common.h, esp. since libavutil is for use by other applications as well.
> > 
> > >  #define FFMAX(a,b) ((a) > (b) ? (a) : (b))
> > >  #define FFMIN(a,b) ((a) > (b) ? (b) : (a))
> > 
> > Adding an FF prefix like here might be nice.
> 
> OK, on it.

Or rather, I will remain them in a day or so unless I hear some
objections.  Sending a patch for this would just amount to spam.

Diego