[Ffmpeg-cvslog] r6733 - trunk/libavformat/mov.c

[Baptiste Coudurier]

michael wrote:
> Author: michael
> Date: Thu Oct 19 12:05:36 2006
> New Revision: 6733
> 
> Modified:
>    trunk/libavformat/mov.c
> 
> Log:
> dont mess with ByteIOContext internal variables (fixes showdown2.mov)
> 
> 
> Modified: trunk/libavformat/mov.c
> ==============================================================================
> --- trunk/libavformat/mov.c	(original)
> +++ trunk/libavformat/mov.c	Thu Oct 19 12:05:36 2006
> @@ -1348,7 +1348,7 @@
>  #ifdef CONFIG_ZLIB
>  static int null_read_packet(void *opaque, uint8_t *buf, int buf_size)
>  {
> -    return -1;
> +    return buf_size;
>  }
>  

Nice it does work indeed. However isn't that dangerous ? Each time
fill_buffer will be called it will return buf_size and if atom.size is
fucked by any way (we read it from file), that will lead to memleak.

Maybe memory should be handled differently by ByteIOContext.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312