[Ffmpeg-cvslog] r8608 - in trunk: Changelog doc/ffmpeg-doc.texi libavcodec/Makefile libavcodec/allcodecs.c libavcodec/avcodec.h libavcodec/tiff.c libavcodec/tiff.h libavcodec/tiffenc.c

[Michel Bardiaux]

Uoti Urpala wrote:
> On Wed, 2007-04-04 at 16:14 +0200, Michel Bardiaux wrote:
>>>> +    add_entry(s, TIFF_WIDTH,             TIFF_LONG,     1,      (uint32_t[]) {s->width});
>> This is a recent gccism; plain simple &s->width works just as well.
> 
> It's not a gccism, 

I stand corrected. It's a C99-ism that should not be allowed in ffmpeg 
sources (unless the policy of supporting 2.95 is reversed).

> and &s->width would not work right.
> (uint32_t[]){s->width} is a standard C (99) compound literal.
> &s->width would be a pointer to int, which is wrong as a pointer to
> uint32_t is needed.

add_entry just needs void*.

-- 
Michel Bardiaux
R&D Director
T +32 [0] 2 790 29 41
F +32 [0] 2 790 29 02
E mailto:mbardiaux at mediaxim.be

Mediaxim NV/SA
Vorstlaan 191 Boulevard du Souverain
Brussel 1160 Bruxelles
http://www.mediaxim.com/