[FFmpeg-cvslog] r9992 - in trunk: ffserver.c libavformat/os_support.h

[Måns Rullgård]

Ramiro Polla <ramiro at lisha.ufsc.br> writes:

> Michael Niedermayer wrote:
>> Hi
>>
>> On Sat, Aug 11, 2007 at 06:07:54PM -0300, Ramiro Polla wrote:
>>
>>> Could this patch be reviewed, please? MinGW is currently broken
>>> because of this.
>>>
>>
>> patch rejected
>>
>> a simple #define closesocket close
>> worked before, now it stopped working, you dont even explain why but just
>> want to add bloat to workaround it by adding an unneeded function ...
>> if it where a static inline in a header but its not
>>
>> and of cousrse must this closesocket() not be exported
>>
>> id say just revert the untested changes which caused this or fix the code
>> (maybe moving the #define closesocket would fix it?)
>>
>>
>
> Thanks for reviewing. After a closer inspection I figured that patch
> was even wronger. closesocket() was not being found because the check
> in configure wasn't suited for Windows.
>
> New simpler patch attached.
>
> Ramiro Polla
> Index: configure
> ===================================================================
> --- configure	(revision 10076)
> +++ configure	(working copy)
> @@ -1630,7 +1630,8 @@
>  check_func2 windows.h GetProcessTimes
>
>  check_func fork
> -check_func closesocket
> +check_func closesocket ||
> +check_func2 winsock2.h closesocket

Please indent the second line 4 spaces.  OK otherwise.

-- 
M?ns Rullg?rd
mans at mansr.com