[Ffmpeg-cvslog] r8123 - trunk/libavformat/swf.c

[Michael Niedermayer]

Hi

On Sun, Feb 25, 2007 at 03:13:13PM +0100, alex wrote:
> Author: alex
> Date: Sun Feb 25 15:13:12 2007
> New Revision: 8123
> 
> Modified:
>    trunk/libavformat/swf.c
> 
> Log:
> use AV_RB32, 

fine but

> swf_mp3_info may be replaced with mpa_decoder_header

NOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO!!!!!!!!!!!!!!!!!!
the broken swf muxer has no business with the mp3 headers this is all
deeply broken none of it is needed, the swf muxer should just take the
packets as is and store them or if needed reorder them by implementing
interleave_packet() or merge and split them with a fifo but i dont
think thats what is needed
there was the very same sick mess in flv*.c ... after removing it alot of
bugs dissapeared

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I count him braver who overcomes his desires than him who conquers his
enemies for the hardest victory is over self. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20070225/1480a9b9/attachment.pgp>