[FFmpeg-cvslog] r9326 - in trunk: doc/hooks.texi vhook/imlib2.c

[Diego Biurrun]

On Sat, Jun 16, 2007 at 07:40:56PM -0300, Ramiro Ribeiro Polla wrote:
> The Wanderer wrote:
> > Diego Biurrun wrote:
> >
> >> On Fri, Jun 15, 2007 at 10:40:14PM +0200, ramiro wrote:
> >>     
> >>> Log:
> >>> Allow user to specify rgb.txt for imlib2 vhook
> >>>
> >>> --- trunk/doc/hooks.texi	(original)
> >>> +++ trunk/doc/hooks.texi	Fri Jun 15 22:40:14 2007
> >>> @@ -67,8 +67,13 @@ with the full path to the font file, as 
> >>>  
> >>> +You can specify the filename to read RGB color names from. If none are
> >>> +specified, these defaults are used: @file{/usr/share/X11/rgb.txt} and
> >>>       
> >> none is specified
> >
> > Actually, given the context, I would say "filenames" (or "filename or
> > filenames", or even "filename(s)") instead of this change.
> >
> > Given that there are multiple files used in the default, is it possible
> > to specify multiple files via the explicit option? If so, precisely how
> > (by repeating the option? by listing multiple files with some delimiter?
> > something else?)?
> >
> > If not, might it be a good idea to allow that?
> >   
> Seems like a good idea. The comments are misleading, so I'll work on it.
> 
> I was going to ask for help on this, but Diego probably read my mind... 
> Can you also take a look at r9342 so that I change the docs in one commit?

Looked OK to me.

> Another thing, is it ok to remove the documentation on top of the vhook 
> .c files? They are on hooks.texi anyways, with a better explanation. 
> Seems like duplication for me.

I'm fine with removing it.  If you feel like it you can add a pointer
to that file, though I don't think it's a must.

Diego