[FFmpeg-cvslog] r8960 - trunk/libavcodec/pcm.c

[Michael Niedermayer]

On Thu, May 10, 2007 at 01:58:51AM +0200, Michael Niedermayer wrote:
> Hi
> 
> 
> On Thu, May 10, 2007 at 01:08:01AM +0200, ramiro wrote:
> > Author: ramiro
> > Date: Thu May 10 01:08:01 2007
> > New Revision: 8960
> > 
> > Log:
> > Factorize usum
> 
> are you pcm.c maintainer? no?
> did you send a patch? no?
> is this change doing anything good besides bloating the code?
> did you benchmark the code?
> 
> if the change would make sense i wouldnt mind if you commited without
> sending a patch but it doesnt, at least its not obvious what good it does
> 
> these functions are static inline and the compiler will if it inlines
> them optimize the check away, and the functions are small so i guess
> gcc will inline them

oops i just realized that you did send a patch which contained this
change together with another change and ive ok-ed it, so iam sorry for
flaming

but still i think this change doesnt do much good and the other part of
the patch doesnt really depend on it
ill benchmark this change tomorrow and reverse it if its not faster
unless you have some comments which would show some other advantage of
it ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20070510/647999d5/attachment.pgp>