[FFmpeg-cvslog] r10889 - trunk/libavcodec/allcodecs.c

[Michael Niedermayer]

On Thu, Nov 01, 2007 at 12:19:58AM +0100, Aurelien Jacobs wrote:
[...]
> > > > Modified:
> > > >    trunk/libavcodec/allcodecs.c
> > > > 
> > > > Modified: trunk/libavcodec/allcodecs.c
> > > > ==============================================================================
> > > > --- trunk/libavcodec/allcodecs.c	(original)
> > > > +++ trunk/libavcodec/allcodecs.c	Wed Oct 31 23:39:10 2007
> > > > @@ -191,7 +191,6 @@ void avcodec_register_all(void)
> > > >      REGISTER_ENCDEC  (LIBGSM_MS, libgsm_ms);
> > > >      REGISTER_ENCODER (LIBMP3LAME, libmp3lame);
> > > >      REGISTER_ENCODER (LIBTHEORA, libtheora);
> > > > -    REGISTER_ENCDEC  (LIBVORBIS, libvorbis);
> > > >      REGISTER_DECODER (MACE3, mace3);
> > > >      REGISTER_DECODER (MACE6, mace6);
> > > >      REGISTER_ENCDEC  (MP2, mp2);
> > > > @@ -215,6 +214,7 @@ void avcodec_register_all(void)
> > > >      REGISTER_ENCDEC  (WMAV1, wmav1);
> > > >      REGISTER_ENCDEC  (WMAV2, wmav2);
> > > >      REGISTER_DECODER (WS_SND1, ws_snd1);
> > > > +    REGISTER_ENCDEC  (LIBVORBIS, libvorbis);
> > > 
> > > I don't like this change very much...
> > 
> > yes yes, i expected flames
> > thanks for proofing that i guessed right ;)
> 
> :-)
> Note that I didn't even talk about wrong sorting ;-)
> BTW: I bet that someone will sort it again at some point,
> just for the shake of sorting.

well, i could add an explicit check somewhere which ensurs that these stay in
that order, or just send diego a big poster he can put on his wall with
"dont sort the REGISTER_*" :)


> 
> > > Default ./configure will enable native vorbis and disable libvorbis.
> > > If user intentionally enable libvorbis, that's probably because he
> > > want to use it. Thus it should probably be preferred over vorbis.
> > 
> > i use --enable-libvorbis but dont want it used by default, what should i
> > do?
> 
> I use --enable-libvorbis and want it used by default, what should i do?
> The fact is that this codec list is not a way to specify user preferred
> codec order...

well, we dont have a users preferred codec list ...

and i think the native codecs should always be preferred unless the user
by changing the default (if that where supported) or explicitly specifies
the codec


> 
> > also binaries from distros will likely have it enabled by default and that
> > might not match what the user wants to use by default
> > 
> > 
> > > Oh, and the best way to fix this anyway is to drop support for
> > > libvorbis decoding ;-)
> > 
> > that would make debuging the decoder harder, so feel free to drop it
> > after you overtook maintainership of our vorbis decoder :)
> 
> No, thanks...
> I thought native decoder was already bullet proof, and that it was
> almost agreed that we should remove libvorbis decoder. It seems I
> was wrong.

i wont stop anyone from removing it, but as long as its there its important
that native vorbis is default or it will become more buggy over time which
will then end in some "we cant make it default now anymore because ..."

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Asymptotically faster algorithms should always be preferred if you have
asymptotical amounts of data
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20071101/1c8c508a/attachment.pgp>