[FFmpeg-cvslog] r10934 - trunk/libavformat/rmdec.c

[Michael Niedermayer]

On Wed, Nov 07, 2007 at 03:58:02PM +0100, Benoit Fouet wrote:
> Kostya wrote:
> > On Tue, Nov 06, 2007 at 05:02:34PM +0100, benoit wrote:
> >   
> >> Author: benoit
> >> Date: Tue Nov  6 17:02:33 2007
> >> New Revision: 10934
> >>
> >> Log:
> >> Split out the MDPR chunk reading into its own function.
> >> Patch by Ronald S. Bultje: rsbultje gmail com
> >> Original thread:[FFmpeg-devel] [PATCH 1/6] rmdec.c: ff_rm_read_mdpr_codecdata()
> >> Date: 11/05/2007 09:21 PM
> >>
> >>
> >> Modified:
> >>    trunk/libavformat/rmdec.c
> >>     
> >
> > Ahem, for some reason this broke some files demuxing.
> >
> > Examples:
> > http://samples.mplayerhq.hu/real/VC-RV30/eiqu-56k.rm
> > http://samples.mplayerhq.hu/real/VC-RV30/141a.rm
> > http://samples.mplayerhq.hu/real/VC-RV40/test.rmvb
> >
> >   
> 
> the following patch should fix and get back to the previous behavior, i
> hadn't noticed it when reviewing...

ok if it restores original behavior

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20071108/97866cde/attachment.pgp>