[FFmpeg-cvslog] r11074 - in trunk/libavcodec/i386: dsputil_mmx.c vc1dsp_mmx.c

[Michael Niedermayer]

On Sat, Nov 24, 2007 at 08:24:39PM +0200, Uoti Urpala wrote:
> On Wed, 2007-11-21 at 23:41 +0100, gpoirier wrote:
> > +void ff_vc1dsp_init_mmx(DSPContext* dsp, AVCodecContext *avctx) {
> 
> Why is this function global when it's included in the only file which
> calls it?

i think that instead of making it static it would be better to seperate
the vc1 stuff cleanly and compile it seperately ...


> 
> At least on my machine this patch also triggers worse optimization
> heurictics in gcc for dsputil_mmx.c, making h264 decoding 4% slower. If

well, you are complaining to the wrong people here, this isnt gccs bugtracker
and not adding new functions to dsputil_mmx.c is not really something we
could do to workaround it ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20071124/53f6dc09/attachment.pgp>