[FFmpeg-cvslog] r10732 - trunk/libavutil/rc4.h

Aurelien Jacobs aurel
Sun Oct 14 14:50:40 CEST 2007


On Sun, 14 Oct 2007 11:51:39 +0200 (CEST)
diego <subversion at mplayerhq.hu> wrote:

> Author: diego
> Date: Sun Oct 14 11:51:38 2007
> New Revision: 10732
> 
> Log:
> Add multiple inclusion guards.
> 
> 
> Modified:
>    trunk/libavutil/rc4.h
> 
> Modified: trunk/libavutil/rc4.h
> ==============================================================================
> --- trunk/libavutil/rc4.h	(original)
> +++ trunk/libavutil/rc4.h	Sun Oct 14 11:51:38 2007
> @@ -18,4 +18,9 @@
>   * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
>   */
>  
> +#ifndef RC4_H
> +#ifndef RC4_H

RC4_H seems quite generic, and might easily clash with another
header. Using AVUTIL_RC4_H would be safer IMO. And I think that's
the convention that was agreed some times ago.

Aurel




More information about the ffmpeg-cvslog mailing list