[FFmpeg-cvslog] r10736 - in trunk/libavcodec: Makefile fraps.c huffman.c huffman.h

[Aurelien Jacobs]

Reimar D?ffinger wrote:

> Hello,
> On Sun, Oct 14, 2007 at 11:19:40PM +0200, aurel wrote:
> >  /**
> > - * decode Fraps v2 packed plane
> > + * first nb_codes nodes.count must be set
> >   */
> > -static int fraps2_decode_plane(FrapsContext *s, uint8_t *dst, int stride, int w,
> > -                               int h, uint8_t *src, int size, int Uoff)
> > +int ff_huff_build_tree(AVCodecContext *avctx, VLC *vlc, int nb_codes,
> > +                       Node nodes[2*nb_codes], huff_cmp_t cmp, int hnode_first)
> 
> I find this Node nodes[2*nb_codes] construct quite ugly, but more
> importantly it reportedly causes compilation to fail on cygwin:
> > huffman.c: In function `get_tree_codes':
> > huffman.c:65: error: prior parameter's size depends on 'nb_codes'

Hum... I thought it would be a nice way to document this parameter.
It seems it is not.
Fixed.

Aurel