[FFmpeg-cvslog] r10859 - trunk/libavformat/electronicarts.c

Aurelien Jacobs aurel
Thu Oct 25 23:10:35 CEST 2007


M?ns Rullg?rd wrote:

> aurel <subversion at mplayerhq.hu> writes:
> 
> > Author: aurel
> > Date: Thu Oct 25 22:38:49 2007
> > New Revision: 10859
> >
> > Log:
> > add parsing of 1SNh header in the EA demuxer
> >
> > Modified:
> >    trunk/libavformat/electronicarts.c
> >
> > Modified: trunk/libavformat/electronicarts.c
> > ==============================================================================
> > --- trunk/libavformat/electronicarts.c	(original)
> > +++ trunk/libavformat/electronicarts.c	Thu Oct 25 22:38:49 2007
> > @@ -27,6 +27,10 @@
> >  #include "avformat.h"
> >
> >  #define SCHl_TAG MKTAG('S', 'C', 'H', 'l')
> > +#define _SNh_TAG MKTAG('1', 'S', 'N', 'h')    /* 1SNx header */
> > +#define EACS_TAG MKTAG('E', 'A', 'C', 'S')
> > +#define _SNd_TAG MKTAG('1', 'S', 'N', 'd')    /* 1SNx data */
> > +#define _SNe_TAG MKTAG('1', 'S', 'N', 'e')    /* 1SNx end */
> 
> Names starting with _ followed by uppercase are reserved.  Please
> rename these.

Ouch... I considered those names slightly ugly, but I didn't even noticed
they used reserved _ + uppercase.
Thanks for noticing ! Fixed.

Aurel




More information about the ffmpeg-cvslog mailing list