[FFmpeg-cvslog] r14852 - in trunk/libavdevice: v4l.c v4l2.c

[Michael Niedermayer]

On Tue, Aug 19, 2008 at 10:49:30PM +0100, M?ns Rullg?rd wrote:
> michael <subversion at mplayerhq.hu> writes:
> 
> > Author: michael
> > Date: Tue Aug 19 23:20:39 2008
> > New Revision: 14852
> >
> > Log:
> > Workaround bug in types.h that has typedef __u64 under #ifndef __STRICT_ANSI__.
> >
> > Modified:
> >    trunk/libavdevice/v4l.c
> >    trunk/libavdevice/v4l2.c
> >
> > Modified: trunk/libavdevice/v4l.c
> > ==============================================================================
> > --- trunk/libavdevice/v4l.c	(original)
> > +++ trunk/libavdevice/v4l.c	Tue Aug 19 23:20:39 2008
> > @@ -19,6 +19,7 @@
> >   * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> >   */
> >
> > +#undef __STRICT_ANSI__ //workaround due to broken kernel headers
> >  #include "config.h"
> >  #include "libavformat/avformat.h"
> >  #include "libavcodec/dsputil.h"
> >
> > Modified: trunk/libavdevice/v4l2.c
> > ==============================================================================
> > --- trunk/libavdevice/v4l2.c	(original)
> > +++ trunk/libavdevice/v4l2.c	Tue Aug 19 23:20:39 2008
> > @@ -27,6 +27,7 @@
> >   * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
> >   */
> >
> > +#undef __STRICT_ANSI__ //workaround due to broken kernel headers
> >  #include "config.h"
> >  #include "libavformat/avformat.h"
> >  #include <unistd.h>
> 
> Why did you do this?  This is the kind of thing that should be
> discussed before being committed.

I did commit this because it fixes a compilation failure on some older
systems, that still seem rather common. That is a failure that was
caused by my -std=c99 addition.
And compared to a check in configure it leaves v4l and v4l2 support
enabled on these systems, which i belive is a significant advantage.

Besides v4l is unmaintained/maintained by me and v4l2 is maintained by
luca who approved this patch.

I do not mind to see this droped and replaced by a configure check once
affected systems have become a rarity but ATM judging from the number of
people being affected by this i would say there are still quite a few
such systems around. And IMHO it would be a pitty if they would loose
v4l/v4l2 support.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080820/c025bd13/attachment.pgp>