[FFmpeg-cvslog] r14956 - trunk/libavformat/matroskadec.c

[Robert Swain]

2008/8/26 Robert Swain <robert.swain at gmail.com>:
> 2008/8/26 Mike Melanson <mike at multimedia.cx>:
>> Michael Niedermayer wrote:
>>> On Mon, Aug 25, 2008 at 11:51:52PM +0200, Aurelien Jacobs wrote:
>>>> Mike Melanson wrote:
>>>>
>>>>> aurel wrote:
>>>>>> Author: aurel
>>>>>> Date: Mon Aug 25 01:57:29 2008
>>>>>> New Revision: 14956
>>>>>>
>>>>>> Log:
>>>>>> matroskadec: don't try to seek to negative timestamp
>>>>>> matroska timestamps are unsigned
>>>>>>
>>>>>>
>>>>>> Modified:
>>>>>>    trunk/libavformat/matroskadec.c
>>>>> Either 14955 or 14956 (both from you) broke the seek regressions.
>>>>> Representative breakage:
>>>> Grmlll... I was pretty sure those commit would change the seek
>>>> regressions. But when I wanted to test this, I just couldn't
>>>> run the test due to the wma regression (floating-point issue IIRC,
>>>> running on amd64).
>>>
>>> Which commit did cause this wma regression test failure?
>>
>> New feature on FATE: click on a build record and the page will only
>> contain the failed tests (not all tests like before). For each failed
>> test, it will show you the last revision when the test worked (for the
>> configuration).
>
> Cool.

No stderr text for the regressions test though. Just "(don't care)". :)

>> One of the 3 revisions following 14755 broke WMA. According to an
>> earlier email, it was 14758, specifically.
>
> Is this only an issue on x86_64? I see no regressions on x86_32.

I did fix a couple of issues in later commits (trying to free shared
tables, incorrect indexing of ff_sine_windows[]) but as far as I know
it should be working now. Is this still currently an issue?

Also, I think someone said wmav2 audio was broken but other wma
worked. I find that strange considering the change but maybe these
window tables are only used in one case and not the other.

Rob