[FFmpeg-cvslog] r16332 - in trunk/libavcodec: faxcompr.c faxcompr.h

[Michael Niedermayer]

On Fri, Dec 26, 2008 at 06:29:50PM +0200, Kostya wrote:
> On Fri, Dec 26, 2008 at 04:05:12PM +0100, michael wrote:
> > Author: michael
> > Date: Fri Dec 26 16:05:12 2008
> > New Revision: 16332
> > 
> > Log:
> > Merge ff_ccitt_unpack_1d and 2d.
>  
> I suspect that using enum TiffCompr is not such a good idea.

i dont see the problem, its not pretty of course but not a real
issue


> We can also use those functions in other decoders, such as raw
> fax files (and maybe PDF in a veeeeery distant future).

#include "tiff.h" and using TiffCompr there will work fine


> 
> Also looks like I've mistaken compression schemes a bit, it should
> be:
> CCITT_RLE: 1D RLE data without EOLs
> G3 - may be pure 1D RLE with EOLs or 2D with EOLs
> G4 - pure 2D data with two EOLs at the very end of coded data
>      (indicating data end)

you have svn write access, dont hesitate to fix it.


> 
> And TIFF uses store options to distinguish between pure 1D and 2D
> modes of G3, you can't distinguish them otherwise (only by decoding
> errors).

the current code works with all tiff files from mphq

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20081226/60df8066/attachment.pgp>