[FFmpeg-cvslog] r11798 - trunk/configure

[Diego Biurrun]

On Sat, Feb 02, 2008 at 04:37:02PM +0100, Michael Niedermayer wrote:
> On Sat, Feb 02, 2008 at 04:23:51PM +0100, Diego Biurrun wrote:
> > On Sat, Feb 02, 2008 at 04:07:35PM +0100, Michael Niedermayer wrote:
> > > On Sat, Feb 02, 2008 at 11:34:53AM +0100, Diego Biurrun wrote:
> > > > On Fri, Feb 01, 2008 at 07:45:26PM +0100, michael wrote:
> > > > > 
> > > > > Log:
> > > > > Mixing declarations and statements is an error, so is any construct
> > > > > depending on sizeof(void) (like void_ptr++)
> > > > > 
> > > > > --- trunk/configure	(original)
> > > > > +++ trunk/configure	Fri Feb  1 19:45:26 2008
> > > > > @@ -1785,6 +1785,8 @@ check_cflags -Wpointer-arith
> > > > >  check_cflags -Wcast-qual
> > > > > +check_cflags -Werror=declaration-after-statement
> > > > > +check_cflags -Werror=pointer-arith
> > > > 
> > > > This is supposed to turn (some) warnings into hard errors, right?  My
> > > > PPC Linux box seems rather unimpressed:
> > > > 
> > > > gcc  -DHAVE_AV_CONFIG_H -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
> > > > -D_ISOC9X_SOURCE -I"/home/diego/src/ffmpeg/ffmpeg" -I"/home/diego/src/ffmpeg/ffmpeg"
> > > > -I"/home/diego/src/ffmpeg/ffmpeg"/libavutil -fomit-frame-pointer
> > > > -maltivec -mabi=altivec -g -Wdeclaration-after-statement -Wall
> > > > -Wno-switch -Wdisabled-optimization -Wpointer-arith -Wredundant-decls
> > > > -Wno-pointer-sign -Wcast-qual -Werror=declaration-after-statement
> > > > -Werror=pointer-arith -O3  -c -o postprocess.o postprocess.c
> > > > In file included from postprocess.c:92:
> > > > postprocess_internal.h: In function ?linecpy?:
> > > > postprocess_internal.h:174: warning: pointer of type ?void *? used in arithmetic
> > > > postprocess_internal.h:174: warning: pointer of type ?void *? used in arithmetic
> > > > In file included from postprocess.c:610:
> > > > postprocess_altivec_template.c: In function ?vertClassify_altivec?:
> > > > postprocess_altivec_template.c:83: warning: ISO C90 forbids mixed declarations and code
> > > > postprocess_altivec_template.c:91: warning: ISO C90 forbids mixed declarations and code
> > > > 
> > > > There are many more of those warnings and eventually compilation
> > > > succeeds.
> > > 
> > > I can confirm this here on x86.
> > > All gcc including 4.3 are affected. I assumed that Werror= works, and only
> > > tested that it didnt break compilation or regression tests. But it seems it
> > > is just buggy like everything else in gcc.
> > > 
> > > Very few (and useless) -Werror do work, like -Werror=parentheses.
> > 
> > I suggest reverting the commit then, it does not have the desired effect
> > and thus is useless clutter.
> 
> If you want to remove it until gcc supports it, thats fine. Though we could
> as well leave it there.

I don't like having compiler options in there that suggest doing
something that they don't.  Warnings of this type might get overlooked
because the compilation does not bomb out.

> Note, yes ill fix the void arith you found ASAP

Thanks.  Note that this is not specific to PPC, but you probably know
that...

Diego