[FFmpeg-cvslog] r12158 - trunk/libavformat/rtpenc.c

[Reimar Döffinger]

Hello,
On Wed, Feb 20, 2008 at 12:41:17PM +0100, Luca Abeni wrote:
> Reimar D?ffinger wrote:
> [...]
> >> I commit this patch because I think it does not decrease the system
> >> security. If we can find a better solution for the security concerns,
> >> I'll be happy to commit it.
> > 
> > The effects are most likely not truly relevant, though as pointed out in my
> > other mail I think there might be (other) good reasons for a flag to set the
> > field to 0, if you have some time to spare to implement that.
> 
> I think this is the "AVFMT_FLAG_USE_TIME" I sent on Friday (plus part of the
> "fix-ntp-time-1.diff" patch), right?
> Maybe the flag name could be better...
> Anyway, if the "avformat flag" patch is accepted I'll happily improve rtpenc.c
> to use the new flag.

I know you prepared something, but my "implement" included getting it
applied which may be some additional work.
And I think I probably should never have posed it as much as a security
issue, it created a lot of confusion (and made you take it far more
seriously that I truly intended).
I just did not really like it (probably mostly due to some previous
discussion about I think some demuxer including a time stamp in the
generated file, which is a serious privacy problem IMO) and quickly
"made up" a reason (while that reason IMO was not really wrong it was not
too helpful either).

Greetings,
Reimar D?ffinger