[FFmpeg-cvslog] r12217 - trunk/libavutil/mem.h

[Michael Niedermayer]

On Mon, Feb 25, 2008 at 08:50:47PM +0100, Reimar D?ffinger wrote:
> On Mon, Feb 25, 2008 at 02:17:36PM -0500, Rich Felker wrote:
> > On Mon, Feb 25, 2008 at 07:59:48PM +0100, Reimar D?ffinger wrote:
> > > On Mon, Feb 25, 2008 at 07:25:49PM +0100, michael wrote:
> > > > Author: michael
> > > > Date: Mon Feb 25 19:25:49 2008
> > > > New Revision: 12217
> > > > 
> > > > Log:
> > > > Make code C conformant.
> > > > 
> > > > 
> > > > Modified:
> > > >    trunk/libavutil/mem.h
> > > > 
> > > > Modified: trunk/libavutil/mem.h
> > > > ==============================================================================
> > > > --- trunk/libavutil/mem.h	(original)
> > > > +++ trunk/libavutil/mem.h	Mon Feb 25 19:25:49 2008
> > > > @@ -36,7 +36,7 @@
> > > >      #define DECLARE_ALIGNED(n,t,v)      __declspec(align(n)) t v
> > > >      #define DECLARE_ASM_CONST(n,t,v)    __declspec(align(n)) static const t v
> > > >  #else
> > > > -    #warning No align and asm directives, this might fail.
> > > > +//  #warning No align and asm directives, this might fail.
> > > >      #define DECLARE_ALIGNED(n,t,v)      t v
> > > >      #define DECLARE_ASM_CONST(n,t,v)    static const t v
> > > 
> > > Well, so we finally end up where I feared: Creating broken code by
> > > default without even a warning at least on some compilers (_if_ it would
> > > finally manage to compile FFmpeg code, at least Sun C one).
> > 
> > Then write and apply the fixes I suggested to configure
> 
> Suggesting is useless, only doing it would be worth anything.

What exactly is the problem?

Is it about adding
check_asm asm '"\n\t"'
to configure

and then putting a #ifdef ENABLE_ASM surrounding this code?

Can we really argue about who adds these 2 lines?

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080225/3c9a8936/attachment.pgp>