[FFmpeg-cvslog] r12241 - trunk/libavformat/mov.c

[Reimar Döffinger]

On Wed, Feb 27, 2008 at 10:26:17AM +0100, Baptiste Coudurier wrote:
> Diego Biurrun wrote:
> > On Tue, Feb 26, 2008 at 07:50:14PM +0100, Baptiste Coudurier wrote:
> >> Reimar D?ffinger wrote:
> >>>> @@ -1451,6 +1529,13 @@ static int mov_read_header(AVFormatConte
> >>>>          sc->ffindex = i;
> >>>>          mov_build_index(mov, st);
> >>>>  
> >>>> +        if (sc->dref_id-1 < sc->drefs_count && sc->drefs[sc->dref_id-1].path) {
> >>>> +            if (url_fopen(&sc->pb, sc->drefs[sc->dref_id-1].path, URL_RDONLY) < 0)
> >>>> +                av_log(s, AV_LOG_ERROR, "stream %d, error opening external essence: %s\n",
> >>>> +                       st->index, strerror(errno));
> >>>> +        } else
> >>>> +            sc->pb = s->pb;
> >>> This must be a joke. Or do you seriously consider it acceptable for a
> >>> demuxer to do url_fopen?!
> >> Please do not whine. Give valid reasons AND suggest another correct way
> >> to handle those files.
> > 
> > So you are going to implement all missing features in MOV?  Even the
> > ones in the MPlayer MOV demuxer? :)
> 
> I suggest Reimar to help with that instead of whining.

Which ones _are_ missing? I only switched MPlayer's default because I am
not aware of anything missing (though there still is the patch for
multiple-fragment mov or what it is called).
And I did add subtitle support, beyond what would have been necessary
for MPlayer.
Obviously a better solution for the multi-codec tracks is missing, but I
am not sure if we even agree on how to solve it (I do not like the idea
of a new API, but without that it can not be supported _fully_ - though
I think it would be good enough for all relevant cases).