[FFmpeg-cvslog] r11388 - trunk/libavcodec/ac3dec.c

[Reimar Döffinger]

Hello,
On Mon, Jan 07, 2008 at 12:27:40PM -0500, Rich Felker wrote:
> On Mon, Jan 07, 2008 at 04:18:59PM +0100, Andreas ?man wrote:
> > jbr wrote:
> > > Author: jbr
> > > Date: Fri Jan  4 00:05:53 2008
> > > New Revision: 11388
> > > 
> > > Log:
> > > only check ac3 crc if AVCodecContext.error_resilience > 0
> > 
> > >  [...]
> > >      /* check for crc mismatch */
> > > +    if(avctx->error_resilience > 0) {
> > 
> > May I suggest that you use the constants available in avcodec.h.
> > Also, since '1' (FF_ER_CAREFUL) is default, perhaps the check should
> > be > FF_ER_CAREFUL.
> 
> I think the intent of ffmpeg is for error resilience to be on by
> default.

Normally I'd say yes, but in this case it's disputable if this shouldn't better
be called error "enhancement" instead of "resilience"...

Greetings,
Reimar D?ffinger