[FFmpeg-cvslog] r11459 - trunk/tools/trasher.c

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> On Wed, Jan 09, 2008 at 12:05:24AM +0100, Diego Biurrun wrote:
>> On Tue, Jan 08, 2008 at 01:54:20AM +0100, michael wrote:
>> > 
>> > Log:
>> > A little proggy i wrote years ago.
>> > This simply writes burts of random data into a file. Great for testing error
>> > robustness/resilience/concealment.
>> > 
>> > --- (empty file)
>> > +++ trunk/tools/trasher.c	Tue Jan  8 01:54:19 2008
>> > @@ -0,0 +1,40 @@
>> > +
>> > +#include <stdio.h>
>> > +#include <stdlib.h>
>> > +#include <time.h>
>> > +#include <inttypes.h>
>> 
>> License header is missing.
>
> add one
>
>> 
>> Also, this segfaults when called without arguments or when the file to
>> open does not exist.
>
> debug it and fix it
> no i dont really care, its not a tool for the user, and any devel can
> read the half page of C to figure it out

This is the kind of attitude that I know is seriously starting annoy
more than one FFmpeg developer.  Sadly, very few seem to dare speak up
about it.

Why is it OK for you commit crap, and tell people they can fix it
themselves, when you make such extreme demands of code submitted by
others?  Don't get me wrong, I usually agree with the comments you
make when reviewing patches.  I do, however, have a very low tolerance
for double standards like this.

Your coding skills have earned you a great deal of respect.  You
should be a little more careful not to ruin it.

-- 
M?ns Rullg?rd
mans at mansr.com