[FFmpeg-cvslog] r14168 - trunk/libavformat/psxstr.c

[The Wanderer]

M?ns Rullg?rd wrote:

> Reimar D?ffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> writes:
> 
>> On Fri, Jul 11, 2008 at 04:41:44PM +0100, M?ns Rullg?rd wrote:

>>> Just as I was thinking the previous commit message was bad...
>> 
>> I do not really mind that one, it is not (supposed to be) a
>> functional change, so what "important" information is missing here?
>> The affected file might not have hurt, but is seems a minor thing
>> to me.
> 
> Yes, there is not supposed to be any functional change.  However,
> bugs happen, and if I'm trying to figure out why something broke,
> it's nice to be able to easily tell which commits might be relevant.
> If the commit message mentions psxstr, I know I can safely ignore it
> when debugging some other format, for instance.  Seeing only
> "simplify", I have to look at the diff to determine the irrelevance
> of this change.

In what context will you see the commit message where the filename is
not already present? The only places I know of offhand which have it are
this mailing list and e.g. 'svn log', both of which already provide it
(the latter implicitly, by way of the filename being specified on the
command line).

Testing now to make sure I'm not being an idiot I do notice that 'svn
log' can be run on a directory to get log results for that entire
hierarchy, but I'm not sure I can think of cases in which it might be
useful to actually do that.

> I'm tempted to add a hook enforcing at least three words in a commit
> message.  It is simply not possible to be accurate enough in only one
> or two words.

I have a tendency to want to take statements like that as a challenge...

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.