[FFmpeg-cvslog] r14168 - trunk/libavformat/psxstr.c

[Michael Niedermayer]

Hi

On Fri, Jul 11, 2008 at 07:51:45PM +0100, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
[...]
> 
> > I dont need a asshat hook that requires me to write "simplified some code"
> > that does not help anyone.
> 
> Why do I get the impression you are being deliberately awkward just
> for the sake of it?  This is just like with your English. You knowing
> what you simplified on the 11th July 2008, doesn't imply that
> everybody else shares that knowledge.

file psxstr.c
message simplify

what you apparently want is
message: psxstr: simplify

this will not give you any more information.


> 
> > The part which is changed should be mentioned only when its not obvious
> > from the file changed.
> >
> > for git, git-log --stat will show you which files changed with the messages.
> 
> Not on a single line, and that's when it becomes most useful.

Then fix git, svn or whatever you use to display the information you want on
a single line.


> Besides, a change to files like utils.c or dsputils.c might be
> affecting only one or two codecs, and in those cases it's nice
> to know this.

yes, and it should be mentioned for these.
A very bad example would be:

"SSE2 optimizations for Monkey's Audio decoder vector functions"

better would have been

"SSE2 optimizations of add/sub/scalarproduct_int16() which are currently
 used only by the Monkey's Audio decoder"


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080711/ae7784cb/attachment.pgp>