[FFmpeg-cvslog] [propchange]: r14167 - svn:log

[Uoti Urpala]

On Sat, 2008-07-12 at 03:59 +0200, Michael Niedermayer wrote:
> On Sat, Jul 12, 2008 at 04:13:28AM +0300, Uoti Urpala wrote:
> > On Sat, 2008-07-12 at 02:27 +0200, Michael Niedermayer wrote:
> > > I also will not play mans secretary for his latest fantasies.
> > > Log messages never included the file or module name, its just mans coming
> > > up with that "great" idea in the last days.
> > 
> > Log messages often didn't include file or module names in the bad old
> > days. Back then revision control was also typically CVS which had
> > per-file history with larger projects represented as groups of loosely
> > linked files with individual histories. Things have changed since then.
> > 
> > Your commit messages are not readable without extra switches to log
> > commands. They don't make sense on http://git.mplayerhq.hu/?p=ffmpeg.
> > They don't work with tools like "git shortlog". That should give you a
> > pretty strong hint that it's not just M?ns's personal idea. Or do you
> > think M?ns personally decided on the default behavior of all those
> > tools?
> 
> If the defaults of git dont work well with the past 5 years of log messages,
> dont use the defaults but use appropriate switches.

That the commit messages in old history are unreadable crap (many of
them so even if you add file names) doesn't mean you have to make new
messages the same.

> The default indention depth of vi doesnt work very well with ffmpeg either,
> still we arent going to change ffmpegs indention to match vi's default.

The context was that you were claiming this was just an idea M?ns came
up with "in the last days". Would you say someone using the default
indentation of vi is just following his random personal idea?

Compared to indentation size commit message contents are a lot more
objectively comparable and less a matter of personal taste or getting
used to. A better analogy would be using indentation vs not using
indentation at all. Good thing FFmpeg wasn't started before using
indentation was common, you'd never have accepted newfangled things like
it if you'd been used to coding without.