[FFmpeg-cvslog] r14267 - trunk/libavcodec/ra288.c

Vitor Sessak vitor1001
Fri Jul 18 02:49:45 CEST 2008


M?ns Rullg?rd wrote:
> Vitor Sessak <vitor1001 at gmail.com> writes:
> 
>> Diego Biurrun wrote:
>>> On Fri, Jul 18, 2008 at 12:42:23AM +0200, vitor wrote:
>>>> Log:
>>>> Simplify
>>> Can we *please* have more descriptive commit messages?  How long can it
>>> take you to explain *what* you simplified?
>> For such obvious cleanups I'm against spending more time thinking about 
>> the commit message than doing the code changes (even more so as what is 
>> "cleaner" is a matter of taste, so it is non trivial to explain why the 
>> new code is better in a commit msg). But if you could suggest anything 
>> better that I could copy-paste for those kind of clean-up commits, I'd 
>> happily do so.
> 
> A simple "ra288:" prefix would suffice in this case.

Then we go back to the flamewar about if the commit messages should be 
understandable with or without seeing the list of changed files. From 
what I followed of the discussion, this is a problem almost only for 
git. Does git have any module support (and in the case of ffmpeg, each 
codec would be a separate module) so that in the history it is marked 
that the "simplify" commit changed only the ra288 module? Adding 
"ra288:" in the log is a bit of metadata duplication...

-Vitor




More information about the ffmpeg-cvslog mailing list