[FFmpeg-cvslog] r27730 - in trunk/libswscale: swscale.c swscale_internal.h

[Michael Niedermayer]

On Sat, Oct 18, 2008 at 11:55:58PM +0200, Vitor Sessak wrote:
> vitor wrote:
>> Author: vitor
>> Date: Wed Oct  8 19:46:22 2008
>> New Revision: 27730
>> Log:
>> Add a new unscaled PAL8 -> RGB converter.
>
> 1000l for me for this patch. I tested it, but without noticing that typing 
> "make" do _not_ rebuild swscale-example. Actually it made a small 
> regression in {PAL,RGB8,BGR8,RGB4,BGR4}->{RGB32, BGR32}.
>
> Three possibilities:
>
> 1- Revert it
> 2- sws_fix10l.diff: fix the actual bug (in rgb2rgb.c)
> 3- sws_hack.diff: just fix my breakage

i do not think 2 or 3 fix the code
the palette is in RGB32 format IIRC so one side of the #ifdef has to be
wrong. Also the rgb24 would need ifdefs which it does not have, or the
palette would have to be converted into a differnt byte order or the
switch case would need to be changed a little

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20081019/af934534/attachment.pgp>