[FFmpeg-cvslog] r15215 - trunk/libavformat/riff.c

[Baptiste Coudurier]

Michael Niedermayer wrote:
> On Thu, Sep 04, 2008 at 08:42:09PM -0700, Mike Melanson wrote:
>> bcoudurier wrote:
>>> Author: bcoudurier
>>> Date: Fri Sep  5 04:20:33 2008
>>> New Revision: 15215
>>>
>>> Log:
>>> simplify bps code by using av_get_bits_per_sample
>>>
>>> Modified:
>>>    trunk/libavformat/riff.c
>> This change broke this regression for all configurations:
> 
> I will revert this change in 24h as it seems baptiste isnt around to
> look into this.
> 
> Also the change looks wrong, as it changes the bps for wma from 16 to 0
> 

Humm, yes, sorry, it seems old code was setting default value to 16,
however I still have problems with wma reg tests here, and when I run
it, I thought this was ok :(

Even if I revert or apply attached patch, I still have the attached diff.

Btw according to specs,
http://msdn.microsoft.com/en-us/library/ms713497.aspx:
"wBitsPerSample

Bits per sample for the wFormatTag format type. If wFormatTag is
WAVE_FORMAT_PCM, then wBitsPerSample should be equal to 8 or 16. For
non-PCM formats, this member must be set according to the manufacturer's
specification of the format tag. If wFormatTag is
WAVE_FORMAT_EXTENSIBLE, this value can be any integer multiple of 8 and
represents the container size, not necessarily the sample size; for
example, a 20-bit sample size is in a 24-bit container. Some compression
schemes cannot define a value for wBitsPerSample, so this member can be 0."

I agree that if it was working with 16 before, better let it as 16.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Smartjog USA Inc.                                http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
-------------- next part --------------
A non-text attachment was scrubbed...
Name: wav_bps_16_default.patch
Type: text/x-diff
Size: 763 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080906/3a5bf132/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: wma.diff
Type: text/x-diff
Size: 606 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080906/3a5bf132/attachment.diff>