[FFmpeg-cvslog] r18657 - trunk/libavformat/mp3.c

[Michael Niedermayer]

On Wed, Apr 22, 2009 at 08:55:02AM +0200, Benoit Fouet wrote:
> On 04/22/2009 04:58 AM, michael wrote:
> > Author: michael
> > Date: Wed Apr 22 04:58:20 2009
> > New Revision: 18657
> >
> > Log:
> > Require 4 instead of 3 frames for detecting mp3,
> > fixes misdetection of mpegps_mp3_unrecognized_format.mpg (issue997)
> >
> > Modified:
> >    trunk/libavformat/mp3.c
> >
> > Modified: trunk/libavformat/mp3.c
> > ==============================================================================
> > --- trunk/libavformat/mp3.c	Wed Apr 22 04:29:11 2009	(r18656)
> > +++ trunk/libavformat/mp3.c	Wed Apr 22 04:58:20 2009	(r18657)
> > @@ -391,10 +391,11 @@ static int mp3_read_probe(AVProbeData *p
> >      }
> >      if   (first_frames>=3) return AVPROBE_SCORE_MAX/2+1;
> >      else if(max_frames>500)return AVPROBE_SCORE_MAX/2;
> > -    else if(max_frames>=3) return AVPROBE_SCORE_MAX/4;
> > +    else if(max_frames>=4) return AVPROBE_SCORE_MAX/4;
> >      else if(buf0!=p->buf)  return AVPROBE_SCORE_MAX/4-1;
> >      else if(max_frames>=1) return 1;
> >      else                   return 0;
> > +//mpegps_mp3_unrecognized_format.mpg has max_frames=3
> >   
> 
> is this comment really needed ?

needed? no but its usefull, when one reads the code, such comments are
much closer than the log messages of the commits that commited them

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored awnser#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20090423/e6a056f6/attachment.pgp>