[FFmpeg-cvslog] r19695 - trunk/libavcodec/twinvq.c

[Reimar Döffinger]

On Tue, Aug 25, 2009 at 04:16:37AM +0200, Vitor Sessak wrote:
> Diego Biurrun wrote:
> > On Mon, Aug 24, 2009 at 07:35:47PM +0200, vitor wrote:
> >> Log:
> >> Cosmetics: add some whitespace around operators
> > 
> > Hmm, was that in reaction to my comment on your commit?
> 
> Yes.
> 
> >> --- trunk/libavcodec/twinvq.c	Mon Aug 24 15:43:33 2009	(r19694)
> >> +++ trunk/libavcodec/twinvq.c	Mon Aug 24 19:35:47 2009	(r19695)
> >> @@ -458,7 +458,7 @@ static void add_peak(int period, int wid
> >>  
> >> -    for (j=-width/2; j < (width+1)/2 && shape < shape_end; j++)
> >> +    for (j=-width/2; j < (width + 1)/2 && shape < shape_end; j++)
> > 
> > There are still some operators on this line that could benefit from
> > whitespace, especially / and =.
> 
> I try to stick to K&R for most of the things but it goes a little too 
> far on extra whitespaces for my taste. I particularly hate doing
> 
> for (i = 0; i < 10; i++)
> 
> instead of
> 
> for (i=0; i < 10; i++)

Which is completely inconsistent in style with _everywhere_.
You use spaces for all other assignments, just not in the for loops,
that is really a bit of an extreme special-case you make there...