[FFmpeg-cvslog] r20502 - in trunk: configure libavcodec/allcodecs.c libavcodec/h263dec.c libavcodec/imgconvert.c libavcodec/vdpau.c libavcodec/vdpau.h libavcodec/vdpau_internal.h libavutil/pixfmt.h

[Alex Converse]

2009/12/7 M?ns Rullg?rd <mans at mansr.com>:
> Uoti Urpala <uoti.urpala at pp1.inet.fi> writes:
>
>> On Mon, 2009-12-07 at 17:56 +0000, M?ns Rullg?rd wrote:
>>> Alex Converse <alex.converse at gmail.com> writes:
>>>
>>> > On Wed, Nov 11, 2009 at 3:16 PM, Jai Menon <jmenon86 at gmail.com> wrote:
>>> >> [...]
>>> >>
>>> >> My understanding (based on [1]) is that mpeg4 asp is supported in
>>> >> packages > 190.32. Shouldn't we use some kind of version checking to
>>> >> make sure we aren't building against older driver packages. Currently,
>>> >> building against older libvdpau leads to build errors (as is expected).
>>> >>
>>> >
>>> > Are we going to revisit this? Several solutions were discussed and in
>>> > the end nothing happened.
>>>
>>> I posted a patch but I need someone to test it. ?Here it is again.
>>
>> I already told you it's wrong (incomplete) the last time you posted it.
>
> I don't remember that, but then I tend not to pay much attention to
> your blatherings.
>

Unfortunately in this particular case he's right. Your patch should
work with some (minimal) ifdeffery to libavcodec/vdpau.[ch]

The body of (or the whole function) "ff_vdpau_mpeg4_decode_picture"
needs to be ifdeffed as does the "VdpPictureInfoMPEG4Part2 mpeg4" in
"struct vdpau_render_state".