[FFmpeg-cvslog] r17068 - in trunk/libavformat: audiointerleave.c audiointerleave.h

[Diego Biurrun]

On Sun, Feb 08, 2009 at 03:09:34PM -0800, Baptiste Coudurier wrote:
> Diego Biurrun wrote:
> > On Sun, Feb 08, 2009 at 10:09:50PM +0100, bcoudurier wrote:
> >> Log:
> >> add static, function unused outside
> > 
> > How about something like
> > 
> >   Declare ff_interleave_new_audio_packet as static, it is not used
> >   outside of audiointerleave.c.  Also remove the function declaration
> >   from the header as it is now static.
> > 
> > May I politely request that you make a bit more of an effort to write
> > descriptive commit messages?  They are an important part of the
> > project documentation.
> 
> Commit messages are _not_ part of project documentation.

> Besides, Im sorry but I still think the commit message cannot be
> separated from the diff, and I won't change my mind.

They can and they often are.  There is no way you can quickly browse
diffs, but you will often look through file or project logs.

Now if you do not use the log this way, fine.  But you are making it
unnecessarily hard, impossible even, for others to use the logs in a
productive way if you write commit messages that provide little
information and thus reduce the value of the logs.

Please accept that others consider the logs important and do rely on
them, even if you do not.

> Now if you want to change the commit message, feel free to do so, but I
> consider commit messages, on which you commented, fine.

They are not sufficient IMNSHO.  How long did it take you to write them?
I suspect just a few seconds, furthere evidenced by the fact that you
seem to be using 'svn commit -m', which is not really suitable for
writing more than a single line.

Diego