[FFmpeg-cvslog] r17314 - in trunk/libavcodec: mpegvideo_xvmc.c xvmc.h

[Robert Swain]

2009/2/15 Reimar D?ffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de>:
> On Sun, Feb 15, 2009 at 09:42:11AM +0100, iive wrote:
>> Log:
>> Rename xvmc_render_state to something with pixfmt in its name.
>
> IMHO "something" describes it quite well.
>
>> -    struct xvmc_render_state *render = (struct xvmc_render_state*)s->current_picture.data[2];
>> +    struct xvmc_pixfmt_render *render = (struct xvmc_pixfmt_render*)s->current_picture.data[2];
>
> I can't see that that name would be any better, the struct neither is,
> nor describes it a PixelFormat Render (I am quite sure that "render" is not
> even an English word, at most it could be a renderer).

'Render' is usually a verb. 'Renderer' is a noun.

I don't understand what the struct name 'xvmc_pixfmt_render' means. At
least before it told you that the struct contained state variables
relating to xvmc rendering. Now it's nonsense. I don't actually see
what that struct or that file (xvmc.h) has to do with pixel formats
either. It seems to contain variables relating to other stuff so I
don't see why it should be named with pixfmt in it. But I haven't been
paying much attention to XvMC.

Regards,
Rob