[FFmpeg-cvslog] r16776 - trunk/libavutil/mem.c

[Michael Niedermayer]

On Sun, Jan 25, 2009 at 07:10:06PM +0100, Reimar D?ffinger wrote:
> On Sun, Jan 25, 2009 at 07:05:57PM +0100, Reimar D?ffinger wrote:
> > On Sun, Jan 25, 2009 at 06:36:48PM +0100, diego wrote:
> > > Author: diego
> > > Date: Sun Jan 25 18:36:48 2009
> > > New Revision: 16776
> > > 
> > > Log:
> > > Do not #include common.h without necessity.
> > > This eliminates the need to work around common.h overriding certain system
> > > functions which are required in this header.
> > 
> > And how is that supposed to work when someone includes common.h before
> > mem.h? Both are part of the public API.
> 
> How silly of me, I did not see this is mem.c, not mem.h.
> It does lead to another question, why is mem.h not included in mem.c?

because diego removed it, or more precissely it was included over common.h
anyway, i also must say that iam rather unhappy about the whole header
changes being commited without prior patches


> IMO it should be, because then mismatches in the function declarations
> result in a compile error instead of possibly runtime bugs.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20090125/036fdf07/attachment.pgp>