[FFmpeg-cvslog] r16823 - trunk/libavcodec/arm/dsputil_arm_s.S

[Måns Rullgård]

Reimar D?ffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> writes:

> On Tue, Jan 27, 2009 at 05:25:23PM +0000, M?ns Rullg?rd wrote:
>> Reimar D?ffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> writes:
>> > On Tue, Jan 27, 2009 at 05:06:51PM +0100, mru wrote:
>> >> Author: mru
>> >> Date: Tue Jan 27 17:06:51 2009
>> >> New Revision: 16823
>> >> 
>> >> Log:
>> >> ARM: reorder some instructions in put_pixels*_arm
>> >
>> > I think a log message is supposed to contain the why (faster, more
>> > readable, ...?)
>> 
>> Such changes are always for speed.
>
> That is a very broad statement, I am sure that someone somewhere has
> modified some assembler code for some other reason.
> And I did think that there was consensus that commit messages should
> provide information beyond what the diff tells, this one definitely
> doesn't, it hardly qualifies even as a summary since it is not much
> shorter than the diff.

And since when do YOU care the slightest about commit messages?  You
are usually among the most vigorous protesters when asked to write
descriptive messages.  So shut up already.

-- 
M?ns Rullg?rd
mans at mansr.com