[FFmpeg-cvslog] r17859 - trunk/libavformat/adtsenc.c

[alexc]

Author: alexc
Date: Fri Mar  6 22:19:16 2009
New Revision: 17859

Log:
ADTS: Increased protection against writing illegal/nonsense files.

Modified:
   trunk/libavformat/adtsenc.c

Modified: trunk/libavformat/adtsenc.c
==============================================================================
--- trunk/libavformat/adtsenc.c	Fri Mar  6 21:51:50 2009	(r17858)
+++ trunk/libavformat/adtsenc.c	Fri Mar  6 22:19:16 2009	(r17859)
@@ -42,7 +42,7 @@ static int decode_extradata(AVFormatCont
     adts->sample_rate_index = get_bits(&gb, 4);
     adts->channel_conf = get_bits(&gb, 4);
 
-    if (adts->objecttype > 3) {
+    if (adts->objecttype > 3U) {
         av_log(s, AV_LOG_ERROR, "MPEG-4 AOT %d is not allowed in ADTS\n", adts->objecttype+1);
         return -1;
     }
@@ -54,6 +54,18 @@ static int decode_extradata(AVFormatCont
         ff_log_missing_feature(s, "PCE based channel configuration", 0);
         return -1;
     }
+    if (get_bits(&gb, 1)) {
+        av_log(s, AV_LOG_ERROR, "960/120 MDCT window is not allowed in ADTS\n");
+        return -1;
+    }
+    if (get_bits(&gb, 1)) {
+        av_log(s, AV_LOG_ERROR, "Scalable configurations are not allowed in ADTS\n");
+        return -1;
+    }
+    if (get_bits(&gb, 1)) {
+        ff_log_missing_feature(s, "Signaled SBR or PS", 0);
+        return -1;
+    }
 
     adts->write_adts = 1;