[FFmpeg-cvslog] r17967 - trunk/libavformat/mxfenc.c

[Baptiste Coudurier]

Reimar D?ffinger wrote:
> On Sun, Mar 15, 2009 at 02:02:51PM +0100, Reimar D?ffinger wrote:
>> Btw. your mxf_parse_mpeg2_frame could probably make good use of the
>> mpegvideo.h header, in particular ff_find_start_code, EXT_START_CODE,
>> GOP_START_CODE, SEQ_START_CODE and PICTURE_START_CODE.
> 
> Also, going by the code in mpeg12enc.c
>> if (pkt->data[i+4]>>6 & 0x01) // closed
> is wrong, it should be
>> if (pkt->data[i+4]>>7)
> closed gop is the highest bit, the one you check should be "broken
> link".

I think you are wrong, time code is 25 bits. >> 7 is the last timecode
picture bit. So closed gop is correct.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no
FFmpeg maintainer                                  http://www.ffmpeg.org