[FFmpeg-cvslog] r18138 - trunk/libavformat/mov.c

[Baptiste Coudurier]

bcoudurier wrote:
> Author: bcoudurier
> Date: Sun Mar 22 03:47:35 2009
> New Revision: 18138
> 
> Log:
> since code now use get_bits_long, allocate padding buffer
> 
> Modified:
>    trunk/libavformat/mov.c
> 
> Modified: trunk/libavformat/mov.c
> ==============================================================================
> --- trunk/libavformat/mov.c	Sun Mar 22 03:04:28 2009	(r18137)
> +++ trunk/libavformat/mov.c	Sun Mar 22 03:47:35 2009	(r18138)
> @@ -1166,7 +1166,7 @@ static int mov_read_stsz(MOVContext *c, 
>  
>      num_bytes = (entries*field_size+4)>>3;
>  
> -    buf = av_malloc(num_bytes);
> +    buf = av_malloc(num_bytes+FF_INPUT_BUFFER_PADDING_SIZE);
>      if (!buf) {
>          av_freep(&sc->sample_sizes);
>          return AVERROR(ENOMEM);

Humm, I believe this need a malloc overflow check, right ?

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no
FFmpeg maintainer                                  http://www.ffmpeg.org