[FFmpeg-cvslog] r18088 - trunk/libavformat/mxfdec.c

[Reimar Döffinger]

On Sun, Mar 22, 2009 at 04:34:55AM -0700, Baptiste Coudurier wrote:
> On 3/22/2009 3:37 AM, Reimar D?ffinger wrote:
> > Not even remotely, you are missing the cases
> > metadata_sets_count == INT_MAX -> metadata_sets_count + 1 == INT_MIN < your constant
> > metadata_sets_count < -1 -> metadata_sets_count + 1 < 0 < your constant
> 
> I don't get it,
> the case when metadata_sets_count == INT_MAX-1 will fail before the case
> when metadata_sets_count == INT_MAX because of the >= , no ?
> Then it's over, ideally, it will return failure and stop.

Sure, if you never set (except to 0)/increment metadata_sets_count
outside that function it works.