[FFmpeg-cvslog] r20326 - trunk/libavformat/Makefile

[Justin Ruggles]

Justin Ruggles wrote:

> M?ns Rullg?rd wrote:
> 
>> Justin Ruggles <justin.ruggles at gmail.com> writes:
>>
>>> diego wrote:
>>>
>>>> Author: diego
>>>> Date: Tue Oct 20 00:32:32 2009
>>>> New Revision: 20326
>>>>
>>>> Log:
>>>> The MP2/MP3 muxer uses ff_id3v2_tags, so add the correct object dependency.
>>>>
>>>> Modified:
>>>>    trunk/libavformat/Makefile
>>>>
>>>> Modified: trunk/libavformat/Makefile
>>>> ==============================================================================
>>>> --- trunk/libavformat/Makefile	Tue Oct 20 00:26:52 2009	(r20325)
>>>> +++ trunk/libavformat/Makefile	Tue Oct 20 00:32:32 2009	(r20326)
>>>> @@ -106,9 +106,9 @@ OBJS-$(CONFIG_MMF_DEMUXER)              
>>>>  OBJS-$(CONFIG_MMF_MUXER)                 += mmf.o riff.o
>>>>  OBJS-$(CONFIG_MOV_DEMUXER)               += mov.o riff.o isom.o
>>>>  OBJS-$(CONFIG_MOV_MUXER)                 += movenc.o riff.o isom.o avc.o
>>>> -OBJS-$(CONFIG_MP2_MUXER)                 += mp3.o id3v1.o
>>>> +OBJS-$(CONFIG_MP2_MUXER)                 += mp3.o id3v1.o id3v2.o
>>>>  OBJS-$(CONFIG_MP3_DEMUXER)               += mp3.o id3v1.o id3v2.o
>>>> -OBJS-$(CONFIG_MP3_MUXER)                 += mp3.o id3v1.o
>>>> +OBJS-$(CONFIG_MP3_MUXER)                 += mp3.o id3v1.o id3v2.o
>>>>  OBJS-$(CONFIG_MPC_DEMUXER)               += mpc.o id3v1.o id3v2.o apetag.o
>>>>  OBJS-$(CONFIG_MPC8_DEMUXER)              += mpc8.o
>>>>  OBJS-$(CONFIG_MPEG1SYSTEM_MUXER)         += mpegenc.o
>>> From what I can see, the MP2 muxer does not use id3v2 at all, only id3v1.
>> Is that intentional?
> 
> Good point.  Looking back at the original May 2007 thread, it seems the
> topic was brought up.  I don't think the final intent actually made it
> to the code though... unless it was changed later.
> 
> http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2007-May/029824.html

Hmmm. More supporting evidence.

http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2007-August/033601.html

so it seems it is intentional.

-Justin