[FFmpeg-cvslog] r20406 - trunk/libavcodec/Makefile

[Reimar Döffinger]

On Wed, Oct 28, 2009 at 08:47:01PM +0000, M?ns Rullg?rd wrote:
> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
> 
> > On Wed, Oct 28, 2009 at 08:49:19PM +0100, mru wrote:
> >> Author: mru
> >> Date: Wed Oct 28 20:49:19 2009
> >> New Revision: 20406
> >> 
> >> Log:
> >> Makefile cosmetics
> >> 
> >> Modified:
> >>    trunk/libavcodec/Makefile
> >> 
> >> Modified: trunk/libavcodec/Makefile
> >> ==============================================================================
> >> --- trunk/libavcodec/Makefile	Wed Oct 28 20:49:16 2009	(r20405)
> >> +++ trunk/libavcodec/Makefile	Wed Oct 28 20:49:19 2009	(r20406)
> >> @@ -702,11 +702,12 @@ $(SUBDIR)cos_tables.c: $(SUBDIR)costable
> >>  $(SUBDIR)sin_tables.c: $(SUBDIR)costablegen$(HOSTEXESUF)
> >>  	./$< sin > $@
> >>  
> >> -ifeq ($(CONFIG_MPEGAUDIO_HP),yes)
> >> +ifdef CONFIG_MPEGAUDIO_HP
> >
> > I copy-and-paste-modified that from subdir.mak:
> > ifeq ($(CONFIG_STATIC),yes)
> > should that maybe be simplified, too?
> 
> Why do people *always* copy&paste from a place that does it wrong?
> You picked the one place in all the makefiles that used this ugly
> syntax.  Why?

Simple, because I remembered it was done (obviously in the past) via ifeq
and thus did a grep for ifeq and ended up there.
The fact that it was the only match probably should have been a hint,
but I was too happy to accept the first working solution :-)