[FFmpeg-cvslog] r21659 - trunk/configure

[Reinhard Tartler]

On Di, Feb 09, 2010 at 02:14:47 (CET), Ramiro Polla wrote:

> On Mon, Feb 8, 2010 at 8:51 PM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
>> Ramiro Polla <ramiro.polla <at> gmail.com> writes:
>>> > libgsm installs headers in a subdirectory, use gsm.h from that subdirectory.
>>> > Approved by Diego at FOSDEM.
>>>
>>> Was this even tested?
>>>
>>> It should need attached patch.
>>>
>>> Attachment (gsm_gsm_h.diff): application/octet-stream, 427 bytes
>>
>> Please apply, my suspicion is that /usr/include/gsm.h was added because some
>> application (FFmpeg or another one) used it instead of /usr/include/gsm/gsm.h.
>
> I'd rather wait for Diego's or Reinhard's comment first. The official
> website seems to be down, but you can check the latest source by
> googling for gsm-1.0.13.tar.gz .
>
> make install doesn't seem to do what we are used to, and if there's
> any official directory it installs the headers to it seems to be plain
> "inc", not include/ nor include/gsm/. I'd be inclined to say just
> include/ is more standard...

Quick check among distributions:

Opensuse:
http://www.novell.com/products/linuxpackages/opensuse/libgsm-devel.html

Fedora:
http://koji.fedoraproject.org/koji/rpminfo?rpmID=1450127

Debian:
http://packages.debian.org/sid/i386/libgsm1-dev/filelist

Ubuntu:
http://packages.ubuntu.com/lucid/i386/libgsm1-dev/filelist

All these links indicate that these distros do ship a "compat" symlink:
 /usr/include/gsm.h -> gsm/gsm.h

However, according to mru, it seems that gentoo does not do so. Given
the majority of distros have that, I think we should not check for
<gsm/gsm.h>, but rather for <gsm.h>, rely on the compat symlink, and ask
the gentoo gsm maintainer to include such a symlink in
/usr/include/gsm.h. Other users would need to provide proper -I flags
anyway.

AFAIUI this would mean to revert r21659.


-- 
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4