[FFmpeg-cvslog] r21011 - trunk/libavcodec/x86/dsputil_mmx.c

Gwenole Beauchesne gbeauchesne
Mon Jan 4 13:38:43 CET 2010


On Mon, 4 Jan 2010, Reimar D?ffinger wrote:

>> -        if (mm_flags & FF_MM_SSE){
>> +        if ((mm_flags & FF_MM_SSE) &&
>> +            !(CONFIG_MPEG_XVMC_DECODER && avctx->xvmc_acceleration > 1)){
>> +            /* XvMCCreateBlocks() may not allocate 16-byte aligned blocks */
>>              c->clear_block  = clear_block_sse;
>>              c->clear_blocks = clear_blocks_sse;
>
> While it is probably not relevant I'd like to point out that e.g. NVidia
> drivers can use XvMC just fine without this, so I can't help considering
> this a bit of a hack for XvMC implementations that are not properly
> maintained.

IIRC, it wasn't the case either on my old (X, nvidia driver et al.) system 
with an NVIDIA 6600GT. It also failed on newer systems, Ubuntu 9.04-based 
(X.org 1.6.x probably), and Intel G45 or i945, and also AMD drivers. I 
don't know for VIA since I don't have that.

BTW, what revision of the XvMC specs mention that allocated blocks are 
bound to be 16-byte aligned?



More information about the ffmpeg-cvslog mailing list