[FFmpeg-cvslog] r21225 - trunk/configure

[Måns Rullgård]

Jai Menon <jmenon86 at gmail.com> writes:

> On Sat, Jan 16, 2010 at 1:25 AM, M?ns Rullg?rd <mans at mansr.com> wrote:
>> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
>>
>>> On Fri, Jan 15, 2010 at 07:50:54PM +0100, jai_menon wrote:
>>>> Author: jai_menon
>>>> Date: Fri Jan 15 19:50:53 2010
>>>> New Revision: 21225
>>>>
>>>> Log:
>>>> Do not print VDPAU upgrade notice when configure is invoked
>>>> with `--disable-vdpau`.
>>>>
>>>> Modified:
>>>> ? ?trunk/configure
>>>>
>>>> Modified: trunk/configure
>>>> ==============================================================================
>>>> --- trunk/configure ?Fri Jan 15 15:02:52 2010 ? ? ? ?(r21224)
>>>> +++ trunk/configure ?Fri Jan 15 19:50:53 2010 ? ? ? ?(r21225)
>>>> @@ -2532,7 +2532,7 @@ check_func XOpenDisplay -lX11
>>>> ?check_func XShmCreateImage -lX11 -lXext &&
>>>> ?check_func XFixesGetCursorImage -lX11 -lXext -lXfixes
>>>>
>>>> -if enabled vdpau_vdpau_h; then
>>>> +if ! disabled vdpau && enabled vdpau_vdpau_h; then
>>>
>>> Shouldn't that be something like
>>> enabled_all vdpau vdpau_vdpau_h
>>
>> No, vdpau is never "enabled" at this point. ?It is only implicitly
>> enabled later through _select on various things that need it.
>
> On that note, does adding an `enable vdpau` in the "#configurable
> options" section make sense? because we end up "enabling" it anyway
> during dependency checks.

If it gets enabled anyway, why do it explicitly?

-- 
M?ns Rullg?rd
mans at mansr.com