[FFmpeg-cvslog] r21854 - in trunk/libavutil: pixdesc.c pixdesc.h

[Måns Rullgård]

Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:

> On date Wednesday 2010-07-07 21:44:49 +0100, M?ns Rullg?rd wrote:
>> M?ns Rullg?rd <mans at mansr.com> writes:
>> 
>> > stefano <subversion at mplayerhq.hu> writes:
>> >
>> >> Author: stefano
>> >> Date: Tue Feb 16 21:17:50 2010
>> >> New Revision: 21854
>> >>
>> >> Log:
>> >> Move read_line() and write_line() definition from pixdesc.h to
>> >> pixdesc.c, which are now not anymore marked as static inline.
>> >>
>> >> Fix the inclusion of the private header intreadwrite.h in the public
>> >> header pixdesc.h.
>> >>
>> >> Modified:
>> >>    trunk/libavutil/pixdesc.c
>> >>    trunk/libavutil/pixdesc.h
>> >>
>> >> Modified: trunk/libavutil/pixdesc.c
>> >> ==============================================================================
>> >> --- trunk/libavutil/pixdesc.c	Tue Feb 16 20:26:49 2010	(r21853)
>> >> +++ trunk/libavutil/pixdesc.c	Tue Feb 16 21:17:50 2010	(r21854)
>> >> @@ -22,6 +22,86 @@
>> >>  #include "pixfmt.h"
>> >>  #include "pixdesc.h"
>> >>
>> >> +#include "intreadwrite.h"
>> >> +
>> >> +void read_line(uint16_t *dst, const uint8_t *data[4], const int linesize[4],
>> >> +               const AVPixFmtDescriptor *desc, int x, int y, int c, int w, int read_pal_component)
>> >> +
>> >> +void write_line(const uint16_t *src, uint8_t *data[4], const int linesize[4],
>> >> +                const AVPixFmtDescriptor *desc, int x, int y, int c, int w)
>> >
>> > Both of these functions need av_ prefixes.  Perhaps giving them better
>> > names would be a good idea while at it.  Line of what exactly?
>
> av_read_image_data_line
> av_write_image_data_line
>
>> This is killing half the FATE configurations.  We need to fix it soon.
>
> Has someone an idea of what's wrong with it?

Only properly prefixed symbols are exported from libavutil.

-- 
M?ns Rullg?rd
mans at mansr.com