[FFmpeg-cvslog] r24574 - trunk/tools/patcheck

[Benoit Fouet]

On Thu, 29 Jul 2010 19:03:53 +0200 Michael Niedermayer wrote:
> On Thu, Jul 29, 2010 at 03:49:16PM +0200, Benoit Fouet wrote:
> > On Thu, 29 Jul 2010 15:36:54 +0200 Michael Niedermayer wrote:
> > > On Thu, Jul 29, 2010 at 11:30:43AM +0200, Benoit Fouet wrote:
> > > > On Wed, 28 Jul 2010 17:03:05 +0200 (CEST) michael wrote:
> > > > > Author: michael
> > > > > Date: Wed Jul 28 17:03:05 2010
> > > > > New Revision: 24574
> > > > > 
> > > > > Log:
> > > > > Warn about "/** text" comments.
> > > > > 
> > > > > Modified:
> > > > >    trunk/tools/patcheck
> > > > > 
> > > > > Modified: trunk/tools/patcheck
> > > > > ==============================================================================
> > > > > --- trunk/tools/patcheck	Wed Jul 28 14:08:26 2010	(r24573)
> > > > > +++ trunk/tools/patcheck	Wed Jul 28 17:03:05 2010	(r24574)
> > > > > @@ -51,6 +51,7 @@ hiegrep 'for *\( *'"$ERE_PRITYP"' '  'no
> > > > >  hiegrep '(static|inline|const) *\1'  'duplicate word' $*
> > > > >  hiegrep 'INIT_VLC_USE_STATIC' 'forbidden ancient vlc type' $*
> > > > >  hiegrep '=[-+\*\&] ' 'looks like compound assignment' $*
> > > > > +hiegrep2 '/\*\* *[a-zA-Z0-9].*' '\*/' 'Inconsistently formatted doxygen comment' $*
> > > > >  
> > > > 
> > > > This is true if it's '/\*\*', but not if it's '^/\*\*'
> > > 
> > > elaborate please
> > > 
> > 
> > to me, having the following is correct:
> > /** document foo */
> > foo
> > 
> > Did I miss something in the grep rule?
> 
> the '\*/' i think
> 

In fact, I totally missed what you were trying to catch...
I thought you were trying to track the following:

int foo; /** document foo */

(now that I've re read it, it seems obvious that was not the case,
though; don't know what I was thinking about)

Ben