[FFmpeg-cvslog] r23904 - in trunk: cmdutils.h libavcodec/aac_parser.h libavcodec/ac3.c libavcodec/ac3.h libavcodec/ac3_parser.h libavcodec/ac3tab.c libavcodec/allcodecs.c libavcodec/alsdec.c libavcodec/avcodec.h l...

[Michael Niedermayer]

On Wed, Jun 30, 2010 at 06:46:05PM +0100, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> 
> > On Wed, Jun 30, 2010 at 05:38:06PM +0200, mru wrote:
> >> Author: mru
> >> Date: Wed Jun 30 17:38:06 2010
> >> New Revision: 23904
> > [...]
> >>  /**
> >> - * Sets the libav* libraries log level.
> >> + * Set the libav* libraries log level.
> >>   */
> >>  int opt_loglevel(const char *opt, const char *arg);
> >>  
> >
> > The 3rd vs. 1st person style has been discussed many times and never
> > has a majority for this change existed let alone a consensus. Besides
> > you do not maintain these files that you change and 3rd person is
> > the recommanded style of javadoc & doxygen. And it also sounds much
> > better (to me at least).
> 
> The style was inconsistent.  I made it consistent, something nobody
> else appeared willing to do.  I should have known I'd only be flamed
> for my hard work.

You consistently changed the form the team agreed upon to the your personal
preferance.
Are you an adult developer or a adolescent boy?
ffmpeg is a project with a team that has to work together, one cant just
change other team members code against their will to ones own preferred
style.
Please revert this commit!

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored awnser#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20100630/723c8525/attachment.pgp>