[FFmpeg-cvslog] r22715 - trunk/libavcodec/bitstream.c

Loren Merritt lorenm
Tue May 4 23:13:24 CEST 2010


On Sun, 2 May 2010, M?ns Rullg?rd wrote:

> lorenm <subversion at mplayerhq.hu> writes:
>
>> @@ -258,6 +275,9 @@ int init_vlc_sparse(VLC *vlc, int nb_bit
>>               const void *symbols, int symbols_wrap, int symbols_size,
>>               int flags)
>>  {
>> +    VLCcode buf[nb_codes];
>
> Sorry for not noticing this earlier, but is there any way that
> variable-length array could be removed?  Such beasts are made of pure
> evil.  We should be slaying them, not helping them spread.

a) malloc.
b) unconditionally round it up to 512KB of stack space (that being the 
largest size currently supported).
c) unconditionally round it up to 11KB of stack space (that being the 
largest size currently used (not sure of this)).

--Loren Merritt



More information about the ffmpeg-cvslog mailing list